> -----Original Message----- > From: Peter Maydell <peter.mayd...@linaro.org> > Sent: Friday, August 5, 2022 4:53 PM > To: Zhang, Chen <chen.zh...@intel.com> > Cc: Jason Wang <jasow...@redhat.com>; Li Zhijian <lizhij...@fujitsu.com>; > qemu-dev <qemu-devel@nongnu.org> > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Fri, 5 Aug 2022 at 06:56, Zhang, Chen <chen.zh...@intel.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Jason Wang <jasow...@redhat.com> I wonder under which case > we > > > can see data == NULL? > > > > > > AFAIK, data is either dup via packet_new() or assigned to a pointer > > > to the buf in packet_new_nocopy(). > > > > Yes, you are right. I just checked it for hint of bugs. > > Do you think no need to do it? > > If you think it is a "should never happen unless QEMU is buggy" case, then > assert(data).
OK, I will change it to assert() in V2. Thanks Chen > > thanks > -- PMM
