On Mon, 4 Jul 2022 at 16:23, Daniel P. Berrangé <[email protected]> wrote: > > Historically QEMU has used the 'scripts/checkpatch.pl' script to > validate various style rules but there are a number of issues:
> meson.build | 3 + > tests/Makefile.include | 3 +- > tests/meson.build | 19 +++ > tests/style-excludes.mak | 4 + > tests/style-infra.mak | 265 +++++++++++++++++++++++++++++++++++++++ > tests/style.mak | 24 ++++ >From my point of view the main issue with checkpatch.pl is that nobody in the QEMU developers particularly understands it or is enthusiastic about trying to add more tests to it or adjust the existing ones where QEMU style diverges from the kernel style (but nor are we tracking and upgrading to newer versions of the kernel's script). This seems to be aiming to replace a complex and hard to understand perl script with a complex and hard to understand makefile. I can't say I'm terribly enthusiastic :-/ thanks -- PMM
