> -----Original Message-----
> From: Qemu-devel <qemu-devel-
> [email protected]> On Behalf Of Thomas Huth
> Sent: Wednesday, June 22, 2022 10:03 PM
> To: [email protected]; Riku Voipio <[email protected]>
> Cc: Michael Tokarev <[email protected]>; [email protected]; Paolo
> Bonzini <[email protected]>
> Subject: [PATCH] common-user: Only compile the common user code if
> have_user is set
>
> There is no need to waste cycles here if we only compile the system binaries
> or tools. Additionally, this change is even a hard requirement for building
> the
> tools on systems that do not have an entry in the common-user/host/ folder
> (since common-user/meson.build is trying to add such a path via the
> include_directories() command).
>
> Reported-by: Michael Tokarev <[email protected]>
> Signed-off-by: Thomas Huth <[email protected]>
Looks good to me.
Reviewed-by: Zhang Chen <[email protected]>
> ---
> common-user/meson.build | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/common-user/meson.build b/common-user/meson.build index
> 26212dda5c..ac9de5b9e3 100644
> --- a/common-user/meson.build
> +++ b/common-user/meson.build
> @@ -1,3 +1,7 @@
> +if not have_user
> + subdir_done()
> +endif
> +
> common_user_inc += include_directories('host/' / host_arch)
>
> user_ss.add(files(
> --
> 2.31.1
>
