On Tue, Jun 7, 2022 at 2:34 PM Richard Henderson <
[email protected]> wrote:
> On 6/7/22 13:14, Warner Losh wrote:
> > +static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
> > + abi_long arg2, abi_long arg3, abi_long
> arg4,
> > + abi_long arg5, abi_long arg6, abi_long
> arg7,
> > + abi_long arg8)
> > +{
> > + abi_long ret;
> > +
> > + switch (num) {
> > + default:
> > + gemu_log("qemu: unsupported syscall: %d\n", num);
>
> qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
>
Agreed.
>
> > +#ifdef DEBUG
> > + gemu_log("freebsd syscall %d\n", num);
> > +#endif
>
> Drop this. It's redundant with strace.
>
Yea, it was a quick hack in the past that the wrapper function highlighted
nicely..
> Otherwise,
> Reviewed-by: Richard Henderson <[email protected]>
Thanks!
Warner
