On Sat, May 14, 2022 at 10:54 AM Paolo Bonzini <[email protected]> wrote:
> But I agree that blk_pwrite_zeros shouldn't be a coroutine_fn, because
> of fuse_fallocate and block_load. Alberto, this function is another
> candidate for adding a blk_co_pwrite_zeros + a matching
> generated_co_wrapper.
Thanks for the heads up. In fact, looking at block-backend-io.h,
there's quite a few functions that (AFAICT) we could implement using
generated_co_wrapper:
- blk_pread, blk_preadv, blk_preadv_part
- blk_pwrite, blk_pwritev, blk_pwritev_part
- blk_pwrite_compressed, blk_pwrite_zeroes
- blk_pdiscard
- blk_flush
- blk_truncate, blk_ioctl
Would this make sense?