Hi Alex, On 5/9/22 15:59, Alex Bennée wrote: > Eric Auger <[email protected]> writes: > >> Up to now the virt-machine node contains a virtio-mmio node. >> However no driver produces any PCI interface node. Hence, PCI >> tests cannot be run with aarch64 binary. >> >> Add a GPEX driver node that produces a pci interface node. This latter >> then can be consumed by all the pci tests. One of the first motivation >> was to be able to run the virtio-iommu-pci tests. >> >> We still face an issue with pci hotplug tests as hotplug cannot happen >> on the pcie root bus and require a generic root port. This will be >> addressed later on. >> >> We force cpu=max along with aarch64/virt machine as some PCI tests >> require high MMIO regions to be available. > Where would I be able to force disable-legacy=off for the PCI device in libqos/vhost-user-gpio-pci.c qos_node_consumes("vhost-user-blk-pci", "pci-bus", &opts); I think you can use opts to force disable-legacy to off.
see vhost-user-blk.c. > from? Building on this for GPIO I run into the following: > > subprocess_run_one_test: > /aarch64/virt/generic-pcihost/pci-bus-generic/pci-bus/vhost-user-gpio-pci/vhost-user-gpio/vhost-user-gpio-tests/read-guest-mem/memfile/subprocess > vhost_user_test_setup: -M virt, -cpu max -device > vhost-user-gpio-pci,id=gpio0,addr=04.0,chardev=chr-vhost-user-test > vu_gpio_get_protocol_features: 0x202 > qemu-system-aarch64: -device > vhost-user-gpio-pci,id=gpio0,addr=04.0,chardev=chr-vhost-user-test: Device > doesn't support modern mode, and legacy mode is disabled > Set disable-legacy to off > Broken pipe > > and I think this needs to be applied to the root bus device? you mean the disable-legacy? I guess it should be applied to your device? Eric > > Anyway otherwise it looks OK to me: > > Reviewed-by: Alex Bennée <[email protected]> >
