On 3/26/22 23:34, WANG Xuerui wrote:
This bug is probably lurking there for so long, I cannot even git-blame
my way to the commit first introducing it.
Anyway, because n32 is also TARGET_MIPS64, the address space range
cannot be determined by looking at TARGET_MIPS64 alone. Fix this by only
declaring 48-bit address spaces for n64, or the n32 user emulation will
happily hand out memory ranges beyond the 31-bit limit and crash.
Confirmed to make the minimal reproducing example in the linked issue
behave.
Closes:https://gitlab.com/qemu-project/qemu/-/issues/939
Signed-off-by: WANG Xuerui<[email protected]>
Cc: Philippe Mathieu-Daudé<[email protected]>
Cc: Aurelien Jarno<[email protected]>
Cc: Jiaxun Yang<[email protected]>
Cc: Aleksandar Rikalo<[email protected]>
Cc: Andreas K. Hüttel<[email protected]>
---
target/mips/cpu-param.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This is what I was expecting, when I read the issue report.
Thanks,
Reviewed-by: Richard Henderson <[email protected]>
r~
