On Mon, Mar 21, 2022 at 02:50:25PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > +++ b/qapi/block-export.json
> > > @@ -6,6 +6,7 @@
> > > ##
> > > { 'include': 'sockets.json' }
> > > +{ 'include': 'block-core.json' }
> >
> > Hmm. Does this extra inclusion negatively impact qemu-storage-daemon,
> > since that is why we created block-export.json in the first place (to
> > minimize the stuff that qsd pulled in without needing all of
> > block-core.json)? In other words, would it be better to move
> > BlockDirtyBitmapOrStr to this file?
>
> And include block-export in block-core?
Right now, we have:
qapi/block-core.json "Block core (VM unrelated)" - includes
{common,crypto,job,sockets}.json
qapi/block-export.json "Block device exports" - includes sockets.json
qapi/block.json "Additional block stuff (VM related)" - includes block-core.json
Kevin, you forked off qapi/block-export.json. What do you propose here?
>
> Another alternative is to move BlockDirtyBitmapOrStr to a separate file
> included from both block-export and block-core but that seems to be too much.
Indeed, that feels like a step too far; we already have confusion on
which file to stick new stuff in, and adding another file won't help
that.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
