On Thu, Mar 10, 2022 at 4:01 AM Peter Maydell <[email protected]> wrote:
> On Tue, 8 Mar 2022 at 13:35, Jason Wang <[email protected]> wrote: > > > > The following changes since commit > f45cc81911adc7726e8a2801986b6998b91b816e: > > > > Merge remote-tracking branch > 'remotes/cschoenebeck/tags/pull-9p-20220307' into staging (2022-03-08 > 09:06:57 +0000) > > > > are available in the git repository at: > > > > https://github.com/jasowang/qemu.git tags/net-pull-request > > > > for you to fetch changes up to a10dd1e279fc56cebc7e738925e0db85d0cea089: > > > > vdpa: Expose VHOST_F_LOG_ALL on SVQ (2022-03-08 21:18:41 +0800) > > > > ---------------------------------------------------------------- > > > > ---------------------------------------------------------------- > > Fails to build: > > ../../hw/virtio/vhost-shadow-virtqueue.c: In function 'vhost_svq_start': > ../../hw/virtio/vhost-shadow-virtqueue.c:537:23: error: implicit > declaration of function 'qemu_memalign' > [-Werror=implicit-function-declaration] > 537 | svq->vring.desc = qemu_memalign(qemu_real_host_page_size, > driver_size); > | ^~~~~~~~~~~~~ > ../../hw/virtio/vhost-shadow-virtqueue.c:537:23: error: nested extern > declaration of 'qemu_memalign' [-Werror=nested-externs] > ../../hw/virtio/vhost-shadow-virtqueue.c:537:21: error: assignment to > 'vring_desc_t *' {aka 'struct vring_desc *'} from 'int' makes pointer > from i > nteger without a cast [-Werror=int-conversion] > 537 | svq->vring.desc = qemu_memalign(qemu_real_host_page_size, > driver_size); > | ^ > ../../hw/virtio/vhost-shadow-virtqueue.c:541:21: error: assignment to > 'vring_used_t *' {aka 'struct vring_used *'} from 'int' makes pointer > from i > nteger without a cast [-Werror=int-conversion] > 541 | svq->vring.used = qemu_memalign(qemu_real_host_page_size, > device_size); > | ^ > ../../hw/virtio/vhost-shadow-virtqueue.c: In function 'vhost_svq_stop': > ../../hw/virtio/vhost-shadow-virtqueue.c:579:5: error: implicit > declaration of function 'qemu_vfree' > [-Werror=implicit-function-declaration] > 579 | qemu_vfree(svq->vring.desc); > | ^~~~~~~~~~ > ../../hw/virtio/vhost-shadow-virtqueue.c:579:5: error: nested extern > declaration of 'qemu_vfree' [-Werror=nested-externs] > > > qemu_memalign/qemu_vfree have just moved to their own header file; > you need to rebase and add #include <qemu/memalign.h> in the > appropriate files. > Yes, V2 is sent. Thanks > > thanks > -- PMM > >
