Re: [PATCH v4 3/9] hw/i2c: pmbus: add PEC unsupported warning

[Philippe Mathieu-Daudé]

On 7/3/22 21:05, Titus Rwantare wrote:

Signed-off-by: Titus Rwantare <tit...@google.com>
---
  hw/i2c/pmbus_device.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
index c7ec8e5499..ff644c1d4a 100644
--- a/hw/i2c/pmbus_device.c
+++ b/hw/i2c/pmbus_device.c
@@ -307,6 +307,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd)

case PMBUS_CAPABILITY:

          pmbus_send8(pmdev, pmdev->capability);
+        if (pmdev->capability & BIT(7)) {
+            qemu_log_mask(LOG_UNIMP,
+                          "%s: PEC is enabled but not yet supported.\n",
+                          __func__);
+        }
          break;

case PMBUS_VOUT_MODE: /* R/W byte */

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>