On Fri, Feb 25, 2022 at 03:59:39PM -0500, John Snow wrote: > In _new_session, there's a fairly complex except clause that's used to > give semantic errors to callers of accept() and connect(). We need to > create a new two-step replacement for accept(), so factoring out this > piece of logic will be useful. > > Bolster the comments and docstring here to try and demystify what's > going on in this fairly delicate piece of Python magic. > > (If we were using Python 3.7+, this would be an @asynccontextmanager. We > don't have that very nice piece of magic, however, so this must take an > Awaitable to manage the Exception contexts properly. We pay the price > for platform compatibility.) > > Signed-off-by: John Snow <[email protected]> > --- > python/qemu/aqmp/protocol.py | 89 +++++++++++++++++++++++++----------- > 1 file changed, 62 insertions(+), 27 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
