On Thu, 3 Mar 2022 at 15:55, Steven Sistare <steven.sist...@oracle.com> wrote: > > On 2/24/2022 1:42 PM, Peter Maydell wrote: > > ...it also seems to be making a no-change-of-behaviour rewrite > > of the rest of the file. Is there a reason I'm missing for doing > > that ?
> I'll change the commit message to explain: > > Include CONFIG_DEVICES so that populate_vfio_info is instantiated for > CONFIG_VFIO, and refactor so only one ifdef is needed when new functions > are added in a later patch. > > The later patch is "vfio-pci: cpr part 1 (fd and dma)" I'd prefer it if you split this patch into two patches; these two changes aren't related. thanks -- PMM
