Re: [PATCH v2 20/22] hw/tpm/tpm_tis_isa: Disuse isa_init_irq()

[Stefan Berger]

On 2/22/22 14:34, Bernhard Beschow wrote:

isa_init_irq() has become a trivial one-line wrapper for isa_get_irq().
Use the original instead such that isa_init_irq() can be removed
eventually.

Signed-off-by: Bernhard Beschow <shen...@gmail.com>

Reviewed-by: Stefan Berger <stef...@linux.ibm.com>

---
  hw/tpm/tpm_tis_isa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_tis_isa.c b/hw/tpm/tpm_tis_isa.c
index 10d8a14f19..3477afd735 100644
--- a/hw/tpm/tpm_tis_isa.c
+++ b/hw/tpm/tpm_tis_isa.c
@@ -127,7 +127,7 @@ static void tpm_tis_isa_realizefn(DeviceState *dev, Error 
**errp)
          return;
      }

-    isa_init_irq(ISA_DEVICE(dev), &s->irq, s->irq_num);
+    s->irq = isa_get_irq(ISA_DEVICE(dev), s->irq_num);

      memory_region_add_subregion(isa_address_space(ISA_DEVICE(dev)),
                                  TPM_TIS_ADDR_BASE, &s->mmio);