Alistair, This PULL seems not to include the fixup (which you had intended to squash into it) for the regression introduced (i.e. the condition being inverted): https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/ Without that change this will introduce a regression in Zb[abcs] (i.e., it will be enabled when it shouldn't be, and will be disabled when it should be on).
Please ignore, if I missed a later stand-alone patch (I just looked at the series in Patchworks). Thanks, Philipp. On Wed, 16 Feb 2022 at 07:29, Alistair Francis <[email protected]> wrote: > > From: Philipp Tomsich <[email protected]> > > The Zb[abcs] support code still uses the RISCV_CPU macros to access > the configuration information (i.e., check whether an extension is > available/enabled). Now that we provide this information directly > from DisasContext, we can access this directly via the cfg_ptr field. > > Signed-off-by: Philipp Tomsich <[email protected]> > Reviewed-by: Alistair Francis <[email protected]> > Suggested-by: Richard Henderson <[email protected]> > Reviewed-by: Richard Henderson <[email protected]> > Message-Id: <[email protected]> > Signed-off-by: Alistair Francis <[email protected]> > --- > target/riscv/insn_trans/trans_rvb.c.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/riscv/insn_trans/trans_rvb.c.inc > b/target/riscv/insn_trans/trans_rvb.c.inc > index 810431a1d6..f9bd3b7ec4 100644 > --- a/target/riscv/insn_trans/trans_rvb.c.inc > +++ b/target/riscv/insn_trans/trans_rvb.c.inc > @@ -19,25 +19,25 @@ > */ > > #define REQUIRE_ZBA(ctx) do { \ > - if (!RISCV_CPU(ctx->cs)->cfg.ext_zba) { \ > + if (ctx->cfg_ptr->ext_zba) { \ > return false; \ > } \ > } while (0) > > #define REQUIRE_ZBB(ctx) do { \ > - if (!RISCV_CPU(ctx->cs)->cfg.ext_zbb) { \ > + if (ctx->cfg_ptr->ext_zbb) { \ > return false; \ > } \ > } while (0) > > #define REQUIRE_ZBC(ctx) do { \ > - if (!RISCV_CPU(ctx->cs)->cfg.ext_zbc) { \ > + if (ctx->cfg_ptr->ext_zbc) { \ > return false; \ > } \ > } while (0) > > #define REQUIRE_ZBS(ctx) do { \ > - if (!RISCV_CPU(ctx->cs)->cfg.ext_zbs) { \ > + if (ctx->cfg_ptr->ext_zbs) { \ > return false; \ > } \ > } while (0) > -- > 2.34.1 >
