> -----Original Message----- > From: Richard Henderson <[email protected]> > Sent: Thursday, February 10, 2022 7:22 PM > To: Taylor Simpson <[email protected]>; Philippe Mathieu-Daudé > <[email protected]>; [email protected] > Cc: Paolo Bonzini <[email protected]>; Thomas Huth > <[email protected]> > Subject: Re: [PATCH 11/15] target: Use ArchCPU as interface to target CPU > > On 2/11/22 04:35, Taylor Simpson wrote: > > -#define HEXAGON_CPU_CLASS(klass) \ > > - OBJECT_CLASS_CHECK(HexagonCPUClass, (klass), > TYPE_HEXAGON_CPU) > > -#define HEXAGON_CPU(obj) \ > > - OBJECT_CHECK(HexagonCPU, (obj), TYPE_HEXAGON_CPU) > > -#define HEXAGON_CPU_GET_CLASS(obj) \ > > - OBJECT_GET_CLASS(HexagonCPUClass, (obj), TYPE_HEXAGON_CPU) > > +OBJECT_DECLARE_TYPE(HexagonCPU, HexagonCPUClass, > HEXAGON_CPU) > > > > typedef struct HexagonCPUClass { > > /*< private >*/ > > But it's definitely a smaller change (and matches all of the other targets). > > I do think that the conversion to OBJECT_DECLARE_TYPE should happen first, > via whichever tree you choose.
OK, I'll send a patch. Then, submit a pull request along with the other changes you just looked at. Taylor
