On Mon, Jan 24, 2022 at 10:10:36PM +0800, [email protected] wrote: > @@ -2956,7 +2959,7 @@ int kvm_cpu_exec(CPUState *cpu) > */ > trace_kvm_dirty_ring_full(cpu->cpu_index); > qemu_mutex_lock_iothread(); > - kvm_dirty_ring_reap(kvm_state); > + kvm_dirty_ring_reap(kvm_state, cpu);
Shall we keep passing in NULL in this patch, and make it conditionally taking cpu parameter if dirty limit enabled? Ring reset can still be expensive, so ideally we can still try the best to reap as much PFNs as possible, as long as we still don't need accuracy on RING_FULL exit events. > qemu_mutex_unlock_iothread(); > ret = 0; > break; > -- > 1.8.3.1 > -- Peter Xu
