On 1/28/22 02:46, Peter Maydell wrote:
Now that we have arranged for all the affected board models to not enable the PSCI emulation if they are running guest code at EL3, we can revert commit 4825eaae4fdd56fba0f, thus reinstating commit 9fcd15b9193e819b, without bringing back the regressions that caused us to revert it.For clarity, here is the original commit message of 9fcd15b9193e819b: The SMCCC 1.3 spec section 5.2 says The Unknown SMC Function Identifier is a sign-extended value of (-1) that is returned in the R0, W0 or X0 registers. An implementation must return this error code when it receives: * An SMC or HVC call with an unknown Function Identifier * An SMC or HVC call for a removed Function Identifier * An SMC64/HVC64 call from AArch32 state To comply with these statements, let's always return -1 when we encounter an unknown HVC or SMC call. Signed-off-by: Peter Maydell<[email protected]> --- target/arm/psci.c | 35 ++++++----------------------------- 1 file changed, 6 insertions(+), 29 deletions(-)
Reviewed-by: Richard Henderson <[email protected]> r~
