Re: [PATCH v6 20/33] block: rename bdrv_invalidate_cache_all, blk_invalidate_cache and test_sync_op_invalidate_cache

[Emanuele Giuseppe Esposito]

On 24/01/2022 11:44, Juan Quintela wrote:
>> diff --git a/migration/migration.c b/migration/migration.c
>> index 0652165610..1f06fd2d18 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -499,7 +499,7 @@ static void process_incoming_migration_bh(void *opaque)
>>              global_state_get_runstate() == RUN_STATE_RUNNING))) {
>>          /* Make sure all file formats flush their mutable metadata.
>>           * If we get an error here, just don't restart the VM yet. */
>> -        bdrv_invalidate_cache_all(&local_err);
>> +        bdrv_activate_all(&local_err);
> I guess that we can change the comment here, it just looks weird the
> comment saying flush() and the function nawed _activate()
> 

Do you think it's enough to replace "flush" with "activate"? I am not
sure whether "activate their mutable metadata" is meaningful.

Thank you,
Emanuele