Re: [PATCH 16/30] bsd-user/signal.c: host_to_target_siginfo_noswap

[Richard Henderson]

On 1/10/22 3:19 AM, Warner Losh wrote:
+static inline void host_to_target_siginfo_noswap(target_siginfo_t *tinfo,
+        const siginfo_t *info)
+{
+    int sig, code;
+
+    sig = host_to_target_signal(info->si_signo);

You now have a target signo, so...

+    if (SIGILL == sig || SIGFPE == sig || SIGSEGV == sig || SIGBUS == sig ||
+            SIGTRAP == sig) {

... you need TARGET_SIGFOO in the comparision.

Though, really, I think the categorization that Peter suggested is a better way to 
structure this.


r~