> -----Original Message----- > From: Alistair Francis [mailto:[email protected]] > Sent: Tuesday, January 11, 2022 7:10 AM > To: Jiangyifei <[email protected]> > Cc: [email protected] Developers <[email protected]>; open > list:RISC-V <[email protected]>; [email protected]; open > list:Overall <[email protected]>; [email protected]; Anup Patel > <[email protected]>; Palmer Dabbelt <[email protected]>; Alistair > Francis <[email protected]>; Bin Meng <[email protected]>; > Fanliang (EulerOS) <[email protected]>; Wubin (H) > <[email protected]>; Wanghaibin (D) <[email protected]>; > wanbo (G) <[email protected]>; limingwang (A) > <[email protected]>; Anup Patel <[email protected]> > Subject: Re: [PATCH v4 02/12] target/riscv: Add target/riscv/kvm.c to place > the > public kvm interface > > On Mon, Jan 10, 2022 at 11:48 AM Yifei Jiang via <[email protected]> > wrote: > > > > Add target/riscv/kvm.c to place kvm_arch_* function needed by > > kvm/kvm-all.c. Meanwhile, add kvm support in meson.build file. > > > > Signed-off-by: Yifei Jiang <[email protected]> > > Signed-off-by: Mingwang Li <[email protected]> > > Reviewed-by: Alistair Francis <[email protected]> > > Reviewed-by: Anup Patel <[email protected]> > > --- > > meson.build | 2 + > > target/riscv/kvm.c | 133 > +++++++++++++++++++++++++++++++++++++++ > > target/riscv/meson.build | 1 + > > 3 files changed, 136 insertions(+) > > create mode 100644 target/riscv/kvm.c > > > > diff --git a/meson.build b/meson.build index 53065e96ec..7eaec31a3a > > 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -90,6 +90,8 @@ elif cpu in ['ppc', 'ppc64'] > > kvm_targets = ['ppc-softmmu', 'ppc64-softmmu'] elif cpu in > > ['mips', 'mips64'] > > kvm_targets = ['mips-softmmu', 'mipsel-softmmu', 'mips64-softmmu', > > 'mips64el-softmmu'] > > +elif cpu in ['riscv'] > > + kvm_targets = ['riscv32-softmmu', 'riscv64-softmmu'] > > else > > kvm_targets = [] > > endif > > Can you add this as a separate commit at the end of the series? > > That way we have implemented KVM support before we enable it for users. > > Alistair
Yes, that makes sense. Yifei
