Cc'ing Daniel

On 4/1/22 22:18, Patrick Venture wrote:
From: Peter Foley <pefo...@google.com>

Match the other error handling in this function.


Fixes: e7b347d0bf6 ("net: detect errors from probing vnet hdr flag for TAP devices")

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Signed-off-by: Peter Foley <pefo...@google.com>
---
  net/tap.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/net/tap.c b/net/tap.c
index f716be3e3f..c5cbeaa7a2 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -900,6 +900,7 @@ int net_init_tap(const Netdev *netdev, const char *name,
              if (i == 0) {
                  vnet_hdr = tap_probe_vnet_hdr(fd, errp);
                  if (vnet_hdr < 0) {
+                    ret = -1;
                      goto free_fail;
                  }
              } else if (vnet_hdr != tap_probe_vnet_hdr(fd, NULL)) {


Reply via email to