Re: [PATCH 1/2] hw/display/vmware_vga: only show debug output if DEBUG enabled

[Laurent Vivier]

Le 04/01/2022 à 10:20, Carwyn Ellis a écrit :

Hey,

Thanks for getting back to me.

Yeah will take a look and update when I have a mo.

It's really easy to do, see below for an example:

...

  @@ -297,45 +303,45 @@ static inline bool vmsvga_verify_rect(DisplaySurface 
*surface,
                                        int x, int y, int w, int h)
  {
      if (x < 0) {
-        fprintf(stderr, "%s: x was < 0 (%d)\n", name, x);
+        VMWARE_VGA_DEBUG("%s: x was < 0 (%d)\n", name, x);

replace it by:

    trace_vmsvga_verify_rect_check_neg(name, x);

and in hw/display/trace-events you add:

    vmsvga_verify_rect_check_neg(const char *name, int x) "%s: x was < 0 (%d)"

Thanks,
Laurent