> -----Original Message-----
> From: Richard Henderson [mailto:[email protected]]
> Sent: Sunday, November 21, 2021 6:19 AM
> To: Jiangyifei <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; limingwang (A) <[email protected]>;
> [email protected]; [email protected]; [email protected]; wanbo (G)
> <[email protected]>; Alistair Francis <[email protected]>;
> [email protected]; Wanghaibin (D)
> <[email protected]>; [email protected]; Fanliang (EulerOS)
> <[email protected]>; Wubin (H) <[email protected]>
> Subject: Re: [PATCH v1 03/12] target/riscv: Implement function
> kvm_arch_init_vcpu
> 
> On 11/20/21 8:46 AM, Yifei Jiang wrote:
> > +    id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG,
> KVM_REG_RISCV_CONFIG_REG(isa));
> > +    ret = kvm_get_one_reg(cs, id, &isa);
> > +    if (ret) {
> > +        return ret;
> > +    }
> > +    env->misa_mxl |= isa;
> 
> This doesn't look right.
> I'm sure you meant
> 
>      env->misa_ext = isa;
> 
> 
> r~

Thanks, it will be modified in the next series.

Yifei

Reply via email to