On Tue, Nov 30, 2021 at 04:03:10PM +0100, David Hildenbrand wrote:
> On 30.11.21 09:00, Peter Xu wrote:
> > We should only call the log_global_start/stop when the global dirty track
> > bitmask changes from zero<->non-zero.
> >
> > No real issue reported for this yet probably because no immediate user to
> > enable both dirty rate measurement and migration at the same time. However
> > it'll be good to be prepared for it.
> >
> > Fixes: 63b41db4bc ("memory: make global_dirty_tracking a bitmask")
> > Cc: Hyman Huang <[email protected]>
> > Cc: Paolo Bonzini <[email protected]>
> > Cc: Dr. David Alan Gilbert <[email protected]>
> > Cc: Juan Quintela <[email protected]>
> > Cc: David Hildenbrand <[email protected]>
> > Signed-off-by: Peter Xu <[email protected]>
>
> LGTM
>
> Reviewed-by: David Hildenbrand <[email protected]>
Thanks for the quick review, David.
Just a heads-up that I think it'll be nice to have this as 6.2-rc3 material.
QEMU planning page told me rc3 has just passed (Nov 30th) but still I didn't
see it released, so not sure..
I won't call it a blocker though, so if it missed 6.2 we just copy stable, and
it'll be needed for 6.2 stable branch only.
--
Peter Xu
