Hi, On 10/28/21 17:09, Philippe Mathieu-Daudé wrote: > From: Yanan Wang <[email protected]> > > Now that we have a generic parser smp_parse(), let's add an unit > test for the code. All possible valid/invalid SMP configurations > that the user can specify are covered. > > Signed-off-by: Yanan Wang <[email protected]> > Reviewed-by: Andrew Jones <[email protected]> > Tested-by: Philippe Mathieu-Daudé <[email protected]> > Message-Id: <[email protected]> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > tests/unit/test-smp-parse.c | 594 ++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > tests/unit/meson.build | 1 + > 3 files changed, 596 insertions(+) > create mode 100644 tests/unit/test-smp-parse.c
Could you have a look at this test failure please? https://cirrus-ci.com/task/5823855357853696 MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests/unit G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests/unit tests/unit/test-smp-parse.exe --tap -k Test smp_parse failed! Input configuration: (SMPConfiguration) { .has_cpus = true, cpus = 1, .has_sockets = false, sockets = 0, .has_dies = false, dies = 0, .has_cores = false, cores = 0, .has_threads = false, threads = 0, .has_maxcpus = false, maxcpus = 0, } Should be valid: no Expected error report: Invalid SMP CPUs 1. The min CPUs supported by machine '(null)' is 2 Result is valid: no Output error report: Invalid SMP CPUs 1. The min CPUs supported by machine '(NULL)' is 2 ERROR test-smp-parse - too few tests run (expected 2, got 0) make: *** [Makefile.mtest:576: run-test-70] Error 1
