On 11/5/21 19:42, Peter Maydell wrote: > The mac.h header defines a MAX_CPUS macro. This is confusingly named, > because it suggests it's a generic setting, but in fact it's used > by only the g3beige and mac99 machines. It's also using a single > macro for two values which aren't inherently the same -- if one > of these two machines was updated to support SMP configurations > then it would want a different max_cpus value to the other. > > Since the macro is used in only two places, just expand it out > and get rid of it. If hypothetical future work to support SMP > in these boards needs a compile-time-known limit on the number > of CPUs, we can give it a suitable name at that point. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > Minor bit of cleanup prompted by discussion on > https://gitlab.com/qemu-project/qemu/-/issues/672 > --- > hw/ppc/mac.h | 3 --- > hw/ppc/mac_newworld.c | 3 ++- > hw/ppc/mac_oldworld.c | 3 ++- > 3 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>