On 10/26/21 5:37 AM, Jean-Philippe Brucker wrote:
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter.This affects option default_bus_bypass_iommu which was introduced in the same release: $ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found Rename the parameter to "default-bus-bypass-iommu". Passing "default_bus_bypass_iommu" is still valid since the underscore are transformed automatically. Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option") Reviewed-by: Eric Auger<[email protected]> Reviewed-by: Philippe Mathieu-Daudé<[email protected]> Tested-by: Eric Auger<[email protected]> Signed-off-by: Jean-Philippe Brucker<[email protected]> --- v2: Resending to be merged separately from the equivalent x86 fix, already queued by Paolo [2]. No change other than added review tag. v1:https://lore.kernel.org/qemu-devel/[email protected]/ [2]https://lore.kernel.org/qemu-devel/[email protected]/ --- hw/arm/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to target-arm.next. r~
