> From: Anton Johansson <[email protected]>
> Sent: Monday, October 18, 2021 6:37 AM
> To: Taylor Simpson <[email protected]>; Alessandro Di Federico
> <[email protected]>; [email protected]
> Cc: Brian Cain <[email protected]>; [email protected]; [email protected];
> [email protected]; Alessandro Di Federico <[email protected]>
> Subject: Re: [PATCH v6 08/12] target/hexagon: import lexer for idef-parser
>
> On 9/7/21 18:08, Taylor Simpson wrote:
> +"fNEWREG" |
> +"fCAST4s" { yylval->cast.bit_width = 32;
> + yylval->cast.signedness = SIGNED;
> + return CAST; }
> This doesn't look right - is fNEWREG the same as fCAST4s?
> We followed the definition of fNEWREG in macros.h where it is given as
> #define fNEWREG(VAL) ((uint32_t) (VAL))
Well, that's different from fCAST4s. In particular, one is signed and one is
unsigned.
> +"fCONSTLL" { return CONSTLL; }
> +"fCONSTULL" { return CONSTULL; }
> These can just be converts.
> What is meant by "converts" here?
Type conversion to int64_t/uint64_t.
> +"fHINTJR(RsV)" { /* Emit no token */ }
> Put this in the list of IDENTITY above
> Same as for fNEWREG. We followed the definition in macros.h as
> #define fHINTJR(TARGET) { /* Not modelled in qemu */ } where it no-ops.
OK, as long as it is no-op.
Thanks,
Taylor
