On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote:
Convert instructions with a 5-bit immediate value to decodetree.

Since the 'data format' field is a constant value, use
tcg_constant_i32() instead of a TCG temporary.

Reviewed-by: Richard Henderson<[email protected]>
Reviewed-by: Jiaxun Yang<[email protected]>
Signed-off-by: Philippe Mathieu-Daudé<[email protected]>
---
v2:
- add &msa_i5 format
- TRANS_MSA() calls check_msa_enabled()
- TCG timm is constant
---
  target/mips/tcg/msa.decode      |  16 +++++
  target/mips/tcg/msa_translate.c | 114 ++++++++++----------------------
  2 files changed, 52 insertions(+), 78 deletions(-)

I think you should drop TRANS_MSA and include the check in trans_msa_i5 
instead.  Otherwise,

Reviewed-by: Richard Henderson <[email protected]>

r~

Reply via email to