Philippe Mathieu-Daudé <[email protected]> writes:
> On 10/18/21 12:54, Alex Bennée wrote: >> >> Richard Henderson <[email protected]> writes: >> >>> The base debian10 image contains enough to build qemu; >>> we do not need to repeat that within the new image. >>> >>> Signed-off-by: Richard Henderson <[email protected]> >>> --- >>> tests/docker/dockerfiles/debian-all-test-cross.docker | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker >>> b/tests/docker/dockerfiles/debian-all-test-cross.docker >>> index dedcea58b4..b185b7c15a 100644 >>> --- a/tests/docker/dockerfiles/debian-all-test-cross.docker >>> +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker >>> @@ -8,11 +8,6 @@ >>> # >>> FROM qemu/debian10 >>> >>> -# What we need to build QEMU itself >>> -RUN apt update && \ >>> - DEBIAN_FRONTEND=noninteractive eatmydata \ >>> - apt build-dep -yy qemu >>> - >>> # Add the foreign architecture we want and install dependencies >>> RUN DEBIAN_FRONTEND=noninteractive eatmydata \ >>> apt install -y --no-install-recommends \ >> >> Reviewed-by: Alex Bennée <[email protected]> > > IIUC if we keep --arch-only in the previous step (previous patch), > this step is required here. What for? The --arch-only prevents the attempt to install cross compilers that don't exist on a given host but we install all the cross compilers we need for tests explicitly. -- Alex Bennée
