On 2021/10/8 上午1:47, Richard Henderson wrote:

When target_long is 64-bit, we still want a 32-bit bswap for rev8.
Since this opcode is specific to RV32, we need not conditionalize.

Signed-off-by: Richard Henderson <[email protected]>
Reviewed-by: LIU Zhiwei<[email protected]>

Zhiwei
---
  target/riscv/insn_trans/trans_rvb.c.inc | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/target/riscv/insn_trans/trans_rvb.c.inc 
b/target/riscv/insn_trans/trans_rvb.c.inc
index 66dd51de49..c62eea433a 100644
--- a/target/riscv/insn_trans/trans_rvb.c.inc
+++ b/target/riscv/insn_trans/trans_rvb.c.inc
@@ -232,11 +232,16 @@ static bool trans_rol(DisasContext *ctx, arg_rol *a)
      return gen_shift(ctx, a, EXT_NONE, tcg_gen_rotl_tl);
  }
+static void gen_rev8_32(TCGv ret, TCGv src1)
+{
+    tcg_gen_bswap32_tl(ret, src1, TCG_BSWAP_OS);
+}
+
  static bool trans_rev8_32(DisasContext *ctx, arg_rev8_32 *a)
  {
      REQUIRE_32BIT(ctx);
      REQUIRE_ZBB(ctx);
-    return gen_unary(ctx, a, EXT_NONE, tcg_gen_bswap_tl);
+    return gen_unary(ctx, a, EXT_NONE, gen_rev8_32);
  }
static bool trans_rev8_64(DisasContext *ctx, arg_rev8_64 *a)

Reply via email to