On 07/10/21 22:42, Marc-André Lureau wrote:

    Cc: Gerd Hoffman <[email protected] <mailto:[email protected]>>
    Cc: Volker Rümelin <[email protected] <mailto:[email protected]>>
    Signed-off-by: Paolo Bonzini <[email protected]
    <mailto:[email protected]>>

Not just NetBSD. You could --audio-drv-list=oss and --oss-lib= to specify the library to link with.

Yes, but the question is who would use --oss-lib. And secondarily, if the answer is not "no one", whether they would be accomodated better by a change to QEMU itself.

For example OpenBSD support was removed in 2013:

    Remove OSS support for OpenBSD

    Remove the OSS support for OpenBSD. The OSS API has not been usable
    for quite some time.

    Signed-off-by: Brad Smith <[email protected]>
    Reviewed-by: Laszlo Ersek <[email protected]>
    Reviewed-by: Andreas Färber <[email protected]>
    Signed-off-by: Blue Swirl <[email protected]>

However, if it came back from the dead, one could just

   if not cc.has_header('sys/soundcard.h')
     # not found
-  elif targetos == 'netbsd'
+  elif targetos in ['netbsd', 'openbsd']
     oss = cc.find_library('ossaudio', required: get_option('oss'),
                           kwargs: static_kwargs)
   else

instead of using something like --oss-lib.

Paolo


Reply via email to