Hi Richard,

On 9/27/21 07:07, Richard Henderson wrote:
On 9/26/21 3:15 AM, Philippe Mathieu-Daudé wrote:
On 9/25/21 19:30, WANG Xuerui wrote:
Signed-off-by: WANG Xuerui <g...@xen0n.name>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
---
  tcg/loongarch64/tcg-target.c.inc | 27 +++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)

+static void tcg_target_init(TCGContext *s)
+{
+    tcg_target_available_regs[TCG_TYPE_I32] = ALL_GENERAL_REGS;
+    tcg_target_available_regs[TCG_TYPE_I64] = ALL_GENERAL_REGS;
+
+    tcg_target_call_clobber_regs = ALL_GENERAL_REGS;

If you plan to add support for vector registers later, I think it is
safer to start today with:

        tcg_target_call_clobber_regs = -1ull;

It is not "safer", it is wrong -- there are bits set for which there are no registers.

It seems this patch doesn't need touching after all, and the whole series have been reviewed by now; do I need to send a final revision with all tags collected? Or is this series just waiting for next queue chance / merge window? I'm not quite sure about the QEMU workflow so I'm asking here, apologizes if I'm pinging this too early (maybe I really should wait for another 3 or 4 days before asking this).

r~

Reply via email to