On 9/20/21 12:18 PM, Willian Rampazzo wrote:
From: Cleber Rosa <[email protected]>

The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.

But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.

This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).

Reported-by: Peter Maydell <[email protected]>
Signed-off-by: Cleber Rosa <[email protected]>
[willianr: respin to new Python super format]
Signed-off-by: Willian Rampazzo <[email protected]>

---
v2
   - adjust super call to conform with PEP3135
---
  tests/acceptance/avocado_qemu/__init__.py | 1 +
  1 file changed, 1 insertion(+)


Reviewed-by: Wainer dos Santos Moschetta <[email protected]>



diff --git a/tests/acceptance/avocado_qemu/__init__.py 
b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..d9e1b32aa1 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
          for vm in self._vms.values():
              vm.shutdown()
          self._sd = None
+        super().tearDown()
def fetch_asset(self, name,
                      asset_hash=None, algorithm=None,


Reply via email to