Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state

[Max Filippov]

On Wed, Sep 15, 2021 at 12:32 AM Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote:
> >      if ((flags & CPU_DUMP_FPU) &&
> >          xtensa_option_enabled(env->config, XTENSA_OPTION_FP_COPROCESSOR)) {
> > -        qemu_fprintf(f, "\n");
> > +        g_string_append_printf(buf, "\n");
>
> g_string_append_c(); simpler to move it before this if() statement.

It adds spacing between optional blocks, why does it need to be moved out?

> >      if ((flags & CPU_DUMP_FPU) &&
> >          xtensa_option_enabled(env->config, XTENSA_OPTION_DFP_COPROCESSOR) 
> > &&
> >          !xtensa_option_enabled(env->config, 
> > XTENSA_OPTION_DFPU_SINGLE_ONLY)) {
> > -        qemu_fprintf(f, "\n");
> > +        g_string_append_printf(buf, "\n");
>
> Ditto (move out).

Here as well.

-- 
Thanks.
-- Max