On 9/14/21 6:00 AM, Song Gao wrote:
+static bool trans_bstrpick_w(DisasContext *ctx, arg_bstrpick_w *a)
+{
+ TCGv dest = gpr_dst(ctx, a->rd, EXT_NONE);
+ TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE);
+
+ if ((a->lsbw > a->msbw) || (a->msbw > 31)) {
FWIW, the > 31 check is impossible, due to the 5-bit extract.
+static bool trans_bstrpick_d(DisasContext *ctx, arg_bstrpick_d *a)
+{
+ TCGv dest = gpr_dst(ctx, a->rd, EXT_NONE);
+ TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE);
+
+ if ((a->lsbd > a->msbd) || (a->msbd > 63)) {
Similarly.
But anyway,
Reviewed-by: Richard Henderson <[email protected]>
r~
