The current way the mask is built can overflow with a 64-bit decrementer. Use sextract64() instead.
Cc: Luis Fernando Fujita Pires <[email protected]> Fixes: a8dafa525181 ("target/ppc: Implement large decrementer support for TCG") Signed-off-by: Cédric Le Goater <[email protected]> --- v2: replaced MAKE_64BIT_MASK by sextract64 hw/ppc/ppc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 7375bf4fa910..4f14464c9220 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -876,7 +876,7 @@ static void __cpu_ppc_store_decr(PowerPCCPU *cpu, uint64_t *nextp, bool negative; /* Truncate value to decr_width and sign extend for simplicity */ - value &= ((1ULL << nr_bits) - 1); + value = sextract64(value, 0, nr_bits); negative = !!(value & (1ULL << (nr_bits - 1))); if (negative) { value |= (0xFFFFFFFFULL << nr_bits); -- 2.31.1
