Re: [PATCH 1/3] ui/console: replace QEMUFIFO with Fifo8

[Volker Rümelin]

    @@ -2233,8 +2188,7 @@ static void text_console_do_init(Chardev
    *chr, DisplayState *ds)
         int g_width = 80 * FONT_WIDTH;
         int g_height = 24 * FONT_HEIGHT;

    -    s->out_fifo.buf = s->out_fifo_buf;
    -    s->out_fifo.buf_size = sizeof(s->out_fifo_buf);
    +    fifo8_create(&s->out_fifo, 16);


Missing a fif8_destroy() somewhere

Hi,

there's no function to close a text console. An opened text console 
remains open until QEMU exits. Currently QEMU doesn't free allocated 
text console resources.

With best regards,
Volker


         s->kbd_timer = timer_new_ms(QEMU_CLOCK_REALTIME,
    kbd_send_chars, s);
         s->ds = ds;