On 9/6/21 6:55 AM, Gerd Hoffmann wrote:
> Without this the struct has the wrong size: sizeof() evaluates
> to 16 instead of 13.  In most cases the bug is hidden by the
> fact that guests submits a buffer which is exactly 13 bytes
> long, so the padding added by the compiler is simply ignored.
> 
> But sometimes guests submit a larger buffer and expect a short
> transfer, which does not work properly with the wrong struct
> size.
> 
> Cc: [email protected]

Fixes: a917d384ac0 ("SCSI TCQ support.")

15 years old bug, nice =)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

> Signed-off-by: Gerd Hoffmann <[email protected]>
> ---
>  include/hw/usb/msd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reply via email to