Re: [PATCH v9 03/14] target/riscv: slli.uw is only a valid encoding if shamt first in 64 bits

[Philipp Tomsich]

On Fri, 3 Sept 2021 at 21:45, Richard Henderson <
richard.hender...@linaro.org> wrote:

> On 9/3/21 7:00 PM, Philipp Tomsich wrote:
> > @@ -652,5 +652,15 @@ static bool trans_slli_uw(DisasContext *ctx,
> arg_slli_uw *a)
> >   {
> >       REQUIRE_64BIT(ctx);
> >       REQUIRE_ZBA(ctx);
> > +
> > +    /*
> > +     * The shamt field is only 6 bits for RV64 (with the 7th bit
> > +     * remaining reserved for RV128).  If the reserved bit is set
> > +     * on RV64, the encoding is illegal.
> > +     */
> > +    if (a->shamt >= TARGET_LONG_BITS) {
> > +        return false;
> > +    }
> > +
> >       return gen_shift_imm_fn(ctx, a, EXT_NONE, gen_slli_uw);
>
> As previously stated, drop this patch.
> It is done correctly inside gen_shift_imm_fn.


Good catch: I just looked through the changed translate.c and this does
address the slli.uw case.  I won't be able to retest this tonight, though.
I'll send the updated series as soon as possible, though.