On 7/8/21 5:46 PM, Igor Mammedov wrote: > implicit cast to structure uint8_t member didn't raise error when > assigning value from incorrect enum, but when using build_append_gas() > (next patch) it will error out with (clang): > implicit conversion from enumeration type 'AmlRegionSpace' > to different enumeration type 'AmlAddressSpace' > fix cast error by using correct AML_AS_SYSTEM_MEMORY enum > > Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eric Auger <[email protected]> > --- > CC: [email protected] > CC: [email protected] > CC: [email protected] > CC: [email protected] > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index b88ea4b70a..a07540affb 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -361,7 +361,7 @@ build_spcr(GArray *table_data, BIOSLinker *linker, > VirtMachineState *vms) > > spcr->interface_type = 0x3; /* ARM PL011 UART */ > > - spcr->base_address.space_id = AML_SYSTEM_MEMORY; > + spcr->base_address.space_id = AML_AS_SYSTEM_MEMORY; > spcr->base_address.bit_width = 8; > spcr->base_address.bit_offset = 0; > spcr->base_address.access_width = 1; >
