On Thu, Aug 19, 2021 at 04:26:10PM +0100, Peter Maydell wrote: > On Wed, 18 Aug 2021 at 21:09, Richard Henderson > <[email protected]> wrote: > > > > The comment in cpu-common.c is absolutely correct, we can't > > rely on the ifdef in a file built once. This was only "working" > > because we used ifndef. > > > > Signed-off-by: Richard Henderson <[email protected]> > > Fixes: 1b36e4f5a5de585 > > which moved the properties out of cpu.c and into cpu-common.c > with the remark "There's no reason to keep the property list > separate from the CPU class code" despite there being a big > fat warning comment saying why it can't go in a compiled-once > source file !
Ouch. Sorry about that. :( > > Is there a reason to prefer this patch over just reverting > 1b36e4f5a5de585 ? I agree with reverting the commit. -- Eduardo
