* Peter Maydell ([email protected]) wrote:
> On Thu, 12 Aug 2021 at 12:11, Dr. David Alan Gilbert (git)
> <[email protected]> wrote:
> >
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > ShellCheck points out that tr '[a-z]' actually replaces the []'s
> > and only the a-z is needed.
> >
> > Remove the spurious [] - although in this use it will make no
> > difference.
> >
> > Fixes: bb55b712e8dc4d4eb515144d5c26798fea178cba
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 9a79a004d7..5bb8c2a59d 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then
> > fi
> > echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
> > for drv in $audio_drv_list; do
> > - def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]')
> > + def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z')
> > echo "$def=y" >> $config_host_mak
> > done
> > if test "$alsa" = "yes" ; then
> > -
>
> Reviewed-by: Peter Maydell <[email protected]>
Thanks.
> (Is this the only thing shellcheck complains about in configure?
> I'm guessing not...)
Indeed it's not; there's LOTS of warnings; although most of them are
probably irrelevant; there are also two others at the error level:
In configure line 4406:
if "$ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:]]*$"; then
^-- SC1087: Use braces
when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
which is probably just needing the ${emu} to shut it up.
In configure line 4464:
if !(GIT="$git" "$source_path/scripts/git-submodule.sh"
"$git_submodules_action" "$git_submodules"); then
^-- SC1035: You are missing a required space after the !.
which hmm I've not quite got my head around yet; but maybe that one is
real.
https://www.shellcheck.net/wiki/SC1035 -- You are missing a required space ...
https://www.shellcheck.net/wiki/SC1087 -- Use braces when expanding arrays,...
Dave
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
