On 8/9/21 5:54 PM, Peter Maydell wrote: > In do_setsockopt(), the code path for the options which take a struct > ip_mreq_source (IP_BLOCK_SOURCE, IP_UNBLOCK_SOURCE, > IP_ADD_SOURCE_MEMBERSHIP and IP_DROP_SOURCE_MEMBERSHIP) fails to > check the return value from lock_user(). Handle this in the usual > way by returning -TARGET_EFAULT. > > (In practice this was probably harmless because we'd pass a NULL > pointer to setsockopt() and the kernel would then return EFAULT.) > > Fixes: Coverity CID 1459987 > Signed-off-by: Peter Maydell <[email protected]> > --- > Compile-tested only; I don't have a test case to hand that > uses these socket options. > > linux-user/syscall.c | 3 +++ > 1 file changed, 3 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
