On Thu, Jun 17, 2021 at 05:32:40PM +0300, Vladislav Yaroshchuk wrote: > Add 'vmnet' customizable option and 'vmnet.framework' probe into > configure;
I'm sorry no one else has taken time to review this yet; thanks for your ping. I'm not the network maintainer, and I don't develop on Mac, so I'm uncomfortable doing a full review myself, but I can at least point out: > > Create source files for network client driver, update meson.build; > > Add 'vmnet' into qapi::net::NetClientDriver options list. > > Signed-off-by: Vladislav Yaroshchuk <[email protected]> > --- > +++ b/qapi/net.json > @@ -460,10 +460,11 @@ > # Since: 2.7 > # > # @vhost-vdpa since 5.1 > +# @vmnet since 6.1 Sadly, since no one reviewed, it has missed the 6.1 boat, and you'll have to respin this to call out 6.2 (no need to do that until you have other review comments to address). > ## > { 'enum': 'NetClientDriver', > 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde', > - 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa' ] } > + 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa', > 'vmnet' ] } Long line; please wrap to keep under 80 columns. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
