On 29/07/2021 14.58, Peter Maydell wrote:
On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini <[email protected]> wrote:

From: Marc-AndrĂ© Lureau <[email protected]>

Meson now checks that subprojects do not access files from parent
project. While we all agree this is best practice, libvhost-user also
want to share a few headers with QEMU, and libvhost-user isn't really a
standalone project at this point (although this is making the dependency
a bit more explicit).

Signed-off-by: Marc-AndrĂ© Lureau <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
---
  subprojects/libvhost-user/include/atomic.h       | 1 +
  subprojects/libvhost-user/libvhost-user.c        | 2 +-
  subprojects/libvhost-user/meson.build            | 6 +-----
  subprojects/libvhost-user/standard-headers/linux | 1 +

diff --git a/subprojects/libvhost-user/include/atomic.h 
b/subprojects/libvhost-user/include/atomic.h
new file mode 120000
index 0000000000..8c2be64f7b
--- /dev/null
+++ b/subprojects/libvhost-user/include/atomic.h
@@ -0,0 +1 @@
+../../../include/qemu/atomic.h
\ No newline at end of file

diff --git a/subprojects/libvhost-user/standard-headers/linux 
b/subprojects/libvhost-user/standard-headers/linux
new file mode 120000
index 0000000000..15a2378139
--- /dev/null
+++ b/subprojects/libvhost-user/standard-headers/linux
@@ -0,0 +1 @@
+../../../include/standard-headers/linux
\ No newline at end of file


Should these really be missing the trailing newline ?

It's a symlink, so yes, there does not need to be a newline in here.

 Thomas


Reply via email to