On 7/25/21 1:05 AM, Mark Cave-Ayland wrote:
Commit db1ffc32dd ("qemu/bitops.h: add bitrev8 implementation") introduced a bitrev8() function to reverse the bit ordering required for storing the MAC address in the q800 PROM.This function is not required since QEMU implements its own revbit8() function which does exactly the same thing. Remove the extraneous bitrev8() function and switch its only caller in hw/m68k/q800.c to use revbit8() instead. Signed-off-by: Mark Cave-Ayland<[email protected]> --- hw/m68k/q800.c | 2 +- include/qemu/bitops.h | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) --- I picked this up reading the loongarch thread where I realised that QEMU already has a revbit8() function - I was searching for bitrev8() before deciding that this needed to be added since this was the name of the equivalent function in Linux. I think this is a good candidate for 6.1 still because a) it only has 1 caller which is easy for me to test and b) it prevents anyone else coming along and accidentally using it later. MCA.
Reviewed-by: Richard Henderson <[email protected]> r~
