Re: [PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags

[Richard Henderson]

On 7/17/21 10:58 AM, Peter Maydell wrote:

+static uint32_t cflags_for_breakpoints(CPUState *cpu, target_ulong pc,
+                                       uint32_t cflags)
+{
+    uint32_t bflags = 0;
+
+    if (unlikely(cpu->singlestep_enabled)) {
+        bflags = CF_BP_SSTEP;
+    } else {

Won't this ignore breakpoints when singlestepping ?

Single-step already has priority over other breakpoints:

         /* Pass breakpoint hits to target for further processing */
-        if (!db->singlestep_enabled
-            && unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) {

r~