On Mon, Jul 12, 2021 at 05:18:10PM +0200, Paolo Bonzini wrote: > CONFIG_LINUX_IO_URING is not included in config-host.mak and therefore is > not usable in "when" clauses. Check the availability of the library, > which matches the condition for the non-stubbed version block/io_uring.c. > > At this point, the difference between libraries that have config-host.mak > entries and those that do not is quite confusing. The remaining ~dozen > should be converted in 6.2. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > stubs/meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> > > diff --git a/stubs/meson.build b/stubs/meson.build > index 2e79ff9f4d..d3fa8646b3 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -15,7 +15,9 @@ stub_ss.add(files('fdset.c')) > stub_ss.add(files('fw_cfg.c')) > stub_ss.add(files('gdbstub.c')) > stub_ss.add(files('get-vm-name.c')) > -stub_ss.add(when: 'CONFIG_LINUX_IO_URING', if_true: files('io_uring.c')) > +if linux_io_uring.found() > + stub_ss.add(files('io_uring.c')) > +endif > stub_ss.add(files('iothread-lock.c')) > stub_ss.add(files('isa-bus.c')) > stub_ss.add(files('is-daemonized.c')) > -- > 2.31.1 > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
