On Wed, 30 Jun 2021 at 19:36, Richard Henderson <[email protected]> wrote: > > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: [email protected] > Signed-off-by: Richard Henderson <[email protected]> > --- > target/arm/translate.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-)
Now we end up checking for the single-stepping case twice: once in gen_jmp_tb() etc, and then again indirectly in gen_goto_tb(), because all the callsites to gen_goto_tb() carefully avoid calling it for the is-singlestepping case. That suggests there's more cleanup possible here. For this patch, I guess Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
